review comments resolved

This commit is contained in:
atharva.dev 2025-11-11 16:32:05 +05:30
parent e63b217e4f
commit 043c06e7ac
3 changed files with 4 additions and 4 deletions

View File

@ -11,7 +11,7 @@ export class SecloreProtect implements INodeType {
displayName: 'Seclore', displayName: 'Seclore',
name: 'secloreProtect', name: 'secloreProtect',
icon: 'file:../../icons/seclore.svg', icon: 'file:../../icons/seclore.svg',
usableAsTool: true, // TODO: make it false/ don't allow it to be used as a tool usableAsTool: true,
group: ['transform'], group: ['transform'],
version: 1, version: 1,
subtitle: '={{$parameter["resource"] + ": " + $parameter["operation"]}}', subtitle: '={{$parameter["resource"] + ": " + $parameter["operation"]}}',
@ -59,7 +59,7 @@ export class SecloreProtect implements INodeType {
}, },
options: [ options: [
{ {
name: 'Protect using Policy', name: 'Protect Using Policy',
value: 'protectWithHotFolder', value: 'protectWithHotFolder',
description: 'Protect a file using HotFolder ID configuration', description: 'Protect a file using HotFolder ID configuration',
action: 'Protect file using policy', action: 'Protect file using policy',

View File

@ -189,7 +189,7 @@ export async function protectWithHotFolder(this: IExecuteFunctions): Promise<Nod
Logger.debug(who + 'Getting node parameters', { itemIndex: i }); Logger.debug(who + 'Getting node parameters', { itemIndex: i });
const hotfolderId = this.getNodeParameter('hotfolderId', i) as string; const hotfolderId = this.getNodeParameter('hotfolderId', i) as string;
const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string; const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string;
const correlationId = crypto.randomUUID().toString(); const correlationId = crypto.randomUUID();
const retryCount = this.getNodeParameter('retryCount', i) as number; const retryCount = this.getNodeParameter('retryCount', i) as number;
// Validate required parameters // Validate required parameters

View File

@ -186,7 +186,7 @@ export async function unprotect(this: IExecuteFunctions): Promise<NodeOutput> {
// Get parameters for this item // Get parameters for this item
Logger.debug(who + 'Getting node parameters', { itemIndex: i }); Logger.debug(who + 'Getting node parameters', { itemIndex: i });
const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string; const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string;
const correlationId = crypto.randomUUID().toString(); const correlationId = crypto.randomUUID();
const retryCount = this.getNodeParameter('retryCount', i) as number; const retryCount = this.getNodeParameter('retryCount', i) as number;
Logger.debug(who + 'Asserting binary data', { binaryPropertyName, itemIndex: i }); Logger.debug(who + 'Asserting binary data', { binaryPropertyName, itemIndex: i });