(PS-378) Seclore custom n8n node #1

Merged
atharva.dev merged 22 commits from ticket/PS-378 into main 2025-11-13 04:43:55 +00:00
Member
No description provided.
atharva.dev added 19 commits 2025-11-06 09:31:33 +00:00
atharva.dev requested review from nitin.baranwal 2025-11-06 09:31:39 +00:00
nitin.baranwal requested changes 2025-11-11 10:17:06 +00:00
Dismissed
@ -0,0 +11,4 @@
displayName: 'Seclore',
name: 'secloreProtect',
icon: 'file:../../icons/seclore.svg',
usableAsTool: true, // TODO: make it false/ don't allow it to be used as a tool
First-time contributor

Resolve this TODO

Resolve this TODO
nitin.baranwal marked this conversation as resolved
@ -0,0 +459,4 @@
method: 'POST',
url: `${this.baseUrl}/seclore/drm/filestorage/1.0/upload`,
headers,
body: formData,
First-time contributor

instead of body use formdata which is recommended by n8n for file upload

instead of `body` use `formdata` which is recommended by n8n for file upload
Author
Member

IHttpRequestOptions does not have any field named formdata
the body does accept formdata as input
https://github.com/n8n-io/n8n/blob/master/packages/workflow/src/interfaces.ts#L450

`IHttpRequestOptions` does not have any field named `formdata` the `body` does accept formdata as input https://github.com/n8n-io/n8n/blob/master/packages/workflow/src/interfaces.ts#L450
nitin.baranwal marked this conversation as resolved
@ -0,0 +185,4 @@
}
// Wait before retry (exponential backoff)
await new Promise((resolve) => {
First-time contributor

Instead of this code block, use:

const delayMs = Math.pow(2, attempt) * 1000;
await new Promise((resolve) => setTimeout(resolve, delayMs));

Instead of this code block, use: const delayMs = Math.pow(2, attempt) * 1000; await new Promise((resolve) => setTimeout(resolve, delayMs));
Author
Member
n8n-nodes-seclore\nodes\SecloreProtect\Services\SecloreDRMFileService.ts
  189:36  error  Use of restricted global 'setTimeout' is not allowed  @n8n/community-nodes/no-restricted-globals

lint fails if setTmeout is used

``` n8n-nodes-seclore\nodes\SecloreProtect\Services\SecloreDRMFileService.ts 189:36 error Use of restricted global 'setTimeout' is not allowed @n8n/community-nodes/no-restricted-globals ``` lint fails if setTmeout is used
nitin.baranwal marked this conversation as resolved
@ -0,0 +189,4 @@
Logger.debug(who + 'Getting node parameters', { itemIndex: i });
const hotfolderId = this.getNodeParameter('hotfolderId', i) as string;
const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string;
const correlationId = crypto.randomUUID().toString();
First-time contributor

toString() fxn is redundant here.

toString() fxn is redundant here.
nitin.baranwal marked this conversation as resolved
@ -0,0 +186,4 @@
// Get parameters for this item
Logger.debug(who + 'Getting node parameters', { itemIndex: i });
const binaryPropertyName = this.getNodeParameter('binaryPropertyName', i) as string;
const correlationId = crypto.randomUUID().toString();
First-time contributor

toString() fxn is redundant here.

toString() fxn is redundant here.
nitin.baranwal marked this conversation as resolved
atharva.dev added 2 commits 2025-11-11 11:02:39 +00:00
atharva.dev requested review from nitin.baranwal 2025-11-11 11:03:02 +00:00
nitin.baranwal approved these changes 2025-11-11 11:49:38 +00:00
atharva.dev changed title from [WIP] (PS-378) Seclore custom n8n node to (PS-378) Seclore custom n8n node 2025-11-11 11:51:51 +00:00
atharva.dev added 1 commit 2025-11-12 11:25:53 +00:00
atharva.dev requested review from nitin.baranwal 2025-11-13 04:42:45 +00:00
atharva.dev merged commit 0ade106fd7 into main 2025-11-13 04:43:55 +00:00
atharva.dev deleted branch ticket/PS-378 2025-11-13 04:43:55 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/n8n-nodes-seclore#1
No description provided.